Skip to content

Make symlink prohibition rule catch links with folder target #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2021
Merged

Make symlink prohibition rule catch links with folder target #206

merged 1 commit into from
Jul 19, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jul 19, 2021

The use of FilterOutDirs() on the path list removed symlinks with folder targets, causing rule LS005 to only detect symlinks with file targets. But all types of symlinks are prohibited so this resulted in false negatives.

As reported at #56 (comment)

@per1234
Make symlink prohibition rule catch links with folder target
1e517c4 
The use of `FilterOutDirs()` on the path list removed symlinks with folder targets, causing rule LS005 to only detect
symlinks with file targets. But all types of symlinks are prohibited so this resulted in false negatives.
@per1234 per1234 added type: bug topic: code Related to content of the project itself labels Jul 19, 2021
@per1234 per1234 requested review from silvanocerza and umbynos July 19, 2021 01:52
@codecov-commenter
Copy link

Codecov Report

Merging #206 (1e517c4) into main (8277f9e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   87.86%   87.86%   -0.01%     
==========================================
  Files          43       43              
  Lines        4146     4145       -1     
==========================================
- Hits         3643     3642       -1     
  Misses        392      392              
  Partials      111      111
Flag Coverage Δ
unit 87.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/rule/rulefunction/library.go 94.75% <ø> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8277f9e...1e517c4. Read the comment docs.

@per1234 per1234 merged commit bee3aef into arduino:main Jul 19, 2021
@per1234 per1234 mentioned this pull request Aug 10, 2021
Merged
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umbynos umbynos umbynos approved these changes

@silvanocerza silvanocerza Awaiting requested review from silvanocerza

Assignees

@per1234 per1234

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@per1234 @codecov-commenter @umbynos @rsora